Skip to content

nn/atk: Add AuxBus#56

Open
Naii-the-Baf wants to merge 1 commit intoopen-ead:masterfrom
Naii-the-Baf:AuxBus
Open

nn/atk: Add AuxBus#56
Naii-the-Baf wants to merge 1 commit intoopen-ead:masterfrom
Naii-the-Baf:AuxBus

Conversation

@Naii-the-Baf
Copy link

@Naii-the-Baf Naii-the-Baf commented Feb 25, 2026

Required by BgmParamsChanger in Odyssey.


This change is Reviewable

Copy link

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Naii-the-Baf).


include/nn/atk/AuxBus.h line 7 at r1 (raw file):

namespace nn {
namespace atk {
enum class AuxBus : s32 { Value_0, Value_1, Value_2 };

alAudioEffectFunction::getBusNameFromId

Suggestion:

enum class AuxBus : s32 { AuxBus_A, AuxBus_B, AuxBus_C };

Copy link
Author

@Naii-the-Baf Naii-the-Baf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naii-the-Baf made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on MonsterDruide1).


include/nn/atk/AuxBus.h line 7 at r1 (raw file):

Previously, MonsterDruide1 wrote…

alAudioEffectFunction::getBusNameFromId

Done.

Copy link

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Naii-the-Baf).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants