Conversation
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Naii-the-Baf).
include/nn/atk/AuxBus.h line 7 at r1 (raw file):
namespace nn { namespace atk { enum class AuxBus : s32 { Value_0, Value_1, Value_2 };
alAudioEffectFunction::getBusNameFromId
Suggestion:
enum class AuxBus : s32 { AuxBus_A, AuxBus_B, AuxBus_C };
Naii-the-Baf
left a comment
There was a problem hiding this comment.
@Naii-the-Baf made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on MonsterDruide1).
include/nn/atk/AuxBus.h line 7 at r1 (raw file):
Previously, MonsterDruide1 wrote…
alAudioEffectFunction::getBusNameFromId
Done.
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Naii-the-Baf).
Required by
BgmParamsChangerin Odyssey.This change is